Conversation
ddaspit
left a comment
ddaspit
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93)
src/SIL.Machine/Corpora/PlaceMarkersUsfmUpdateBlockHandler.cs line 181 at r1 (raw file):
adjacentSourceToken > 0 && element.Type == UsfmUpdateBlockElementType.Style && element.Tokens[0].Marker.Last() == '*'
Last is not optimized for strings. It will iterate through all characters in the string.
Enkidu93
left a comment
Enkidu93
left a comment
There was a problem hiding this comment.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @ddaspit)
src/SIL.Machine/Corpora/PlaceMarkersUsfmUpdateBlockHandler.cs line 181 at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
Lastis not optimized for strings. It will iterate through all characters in the string.
Good catch. Done. Wish I could use range operators 🤪
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #314 +/- ##
==========================================
- Coverage 70.83% 70.79% -0.04%
==========================================
Files 390 390
Lines 32729 32715 -14
Branches 4609 4604 -5
==========================================
- Hits 23182 23162 -20
- Misses 8483 8489 +6
Partials 1064 1064 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ddaspit
left a comment
ddaspit
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)
3 participants
This change is